fix: bump cwv (web-vitals) library #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehambley
changed the title
This should net us the changes here GoogleChrome/web-vitals@v1.1.2...v2.1.4 which includes numerous bugfixes and some performance/timing related issues.
leehambley
force-pushed
the
XDN-15826-bump-web-vitals-version
branch
from
36da272
to
373b1f9
Compare
phdunham
approved these changes
Mar 28, 2022
adrien-k
approved these changes
Mar 29, 2022
phdunham
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should net us the changes here GoogleChrome/web-vitals@v1.1.2...v2.1.4 which
includes numerous bugfixes and some performance/timing related issues.
Unfortuantely the CWV underwent a "breaking" change in
1.x.y -> 2.y.zupdate (see here, patch here).Reviewing our code, we rely very minimally on this, and we ought not to be affected, and kudos to Chrome's CWV team for being ultra cautious with their major version bump.
Will seek some assistance from someone more familiar with this project to get this tested and merged.