-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESlint] Clear errors and warnings after running a new npm install without a package-lock.json #4408
[ESlint] Clear errors and warnings after running a new npm install without a package-lock.json #4408
Conversation
Signed-off-by: Randy Lau <randychilau@gmail.com>
Signed-off-by: Randy Lau <randychilau@gmail.com>
Signed-off-by: Randy Lau <randychilau@gmail.com>
Signed-off-by: Randy Lau <randychilau@gmail.com>
Signed-off-by: Randy Lau <randychilau@gmail.com>
Signed-off-by: Randy Lau <randychilau@gmail.com>
Signed-off-by: Randy Lau <randychilau@gmail.com>
Signed-off-by: Randy Lau <randychilau@gmail.com>
Signed-off-by: Randy Lau <randychilau@gmail.com>
Signed-off-by: Randy Lau <randychilau@gmail.com>
🚀 Preview for commit 946c612 at: https://649243f0fdb81e00837a821e--layer5.netlify.app |
Signed-off-by: Randy Lau <randychilau@gmail.com>
🚀 Preview for commit 2566ab1 at: https://64ae36f322f2e87fbd00aedf--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing these issues @randychilau 🥂
LGTM
@randychilau signal if you would prefer to get this PR merged before the the MDX changes, or the vice versa. I think the other one would be better to have lesses merge conflicts. |
Hi @Nikhil-Ladha, Thanks for taking the time to review this PR. Please merge this PR first. I am still doing some more documentation and testing regarding the MDX PR. These warnings/errors appeared when I was working on the MDX PR and thought it should be a separate PR (changes are also in the MDX PR, so there should be no merge conflicts). Thanks again! Cheers, |
Description
This PR fixes a number of eslint errors and warnings that appear
"checklint": "eslint ."
).The errors prevent the ability to commit changes in VSCode (not sure about other IDEs or using command line) indicated by the husky - pre-commit hook exited with code 1 (error).
Additional changes:
package.json for
gatsby-plugin-robots-txt
is because the latest version 1.8.x currently requires Gatsby v5 and is a blocker for doing anpm install
when there is nopackage-lock.json
file, until resolved v1.7.x is the latest version that works with Gatsby v4edit to
src/collections/resources/articles/hpes-adoption-of-meshery-and-meshmap/index.mdx
fileexport 'theme' (imported as 'theme') was not found in '../../../../src/theme/app/themeStyles.js' (possible exports: darktheme, default)
edit
/learn
page for arrows displaying incorrectlybefore:
after:
Notes for Reviewers
The errors and warnings were legitimate issues that were not detected earlier, however with the latest version of
eslint
installed these errors were recorded. (note: the latest eslint version installed "8.43.0" after anew install
command without package-lock.json, current package-lock.json has eslint version "8.28.0").Here are the pages and eslint errors that appeared:
src/components/ConformanceTest-Table/index.js
src/components/Landscape-Table/index.js
src/components/SMI-Table/index.js
src/sections/Community/Handbook/security-vulnerabilities.js
src/sections/Company/Legal/code-of-conduct/index.js
src/sections/Company/Legal/privacy/index.js
src/sections/Company/Legal/terms-of-service/index.js
src/sections/Learn-Layer5/Courses-List/index.js
Happy to answer any questions on this.
Cheers,
Randy
Signed commits