Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Image validator helper func #471

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Image validator helper func #471

wants to merge 6 commits into from

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented Jan 30, 2024 •
edited

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

@sudhanshutech
feat(helper): image validator
e5c042a 
Signed-off-by: sudhanshu dasgupta <dasguptashivam23@gmail.com>
MUzairS15
MUzairS15 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A basic URL verification will be helpful, to validate if the url provided is acutally a uri and not a random text/executable script code.
It will also help to skip the effort of trying to load the url if it's invalid.

@sudhanshutech
fix(validate): restructure and valid url check
f75f5dd 
Signed-off-by: sudhanshu dasgupta <dasguptashivam23@gmail.com>
@sudhanshutech
Merge branch 'master' of https://github.com/sudhanshutech/sistent int…
555e562 
…o add/image/func
@sudhanshutech
fix(conflict): resolve
ce1f940 
Signed-off-by: sudhanshu dasgupta <dasguptashivam23@gmail.com>
@leecalcote
Copy link
Member

A basic URL verification will be helpful, to validate if the url provided is acutally a uri and not a random text/executable script code. It will also help to skip the effort of trying to load the url if it's invalid.

Great comment!

leecalcote and others added 2 commits February 7, 2024 20:55
@leecalcote @aabidsofi19
Update src/custom/Helpers/UrlValidator/image-url-validation.tsx
a62401d 
Co-authored-by: aabidsofi19 <65964225+aabidsofi19@users.noreply.github.com>
Signed-off-by: Lee Calcote <leecalcote@gmail.com>
@sudhanshutech
Merge branch 'master' of https://github.com/sudhanshutech/sistent int…
95fe8d9 
…o add/image/func

Signed-off-by: sudhanshu dasgupta <dasguptashivam23@gmail.com>
@sudhanshutech sudhanshutech added the kind/enhancement Improvement in current feature label Mar 4, 2024
@leecalcote
Copy link
Member

merge conflict...

@leecalcote
Copy link
Member

I'll offer the suggestion that we close this PR. What do you think, @sudhanshutech?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

@captain-Akshay captain-Akshay Awaiting requested review from captain-Akshay

@MUzairS15 MUzairS15 Awaiting requested review from MUzairS15

@aabidsofi19 aabidsofi19 Awaiting requested review from aabidsofi19

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
kind/enhancement Improvement in current feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sudhanshutech @leecalcote @aabidsofi19 @MUzairS15