Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Meshery Cloud UI light palette for backward compatibility #587

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nebula-aac
Copy link
Contributor

Notes for Reviewers

This PR fixes #586

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Antonette Caldwell <134739862+nebula-aac@users.noreply.github.com>
@sudhanshutech
Copy link
Member

i didn't get the purpose of this. @nebula-aac will you please elaborate this

@nebula-aac
Copy link
Contributor Author

This PR is just a draft as I am testing backward compatibility on using the existing theme palette which is already used in Meshery Cloud UI, and the help migrate to use the new options from the new palette that is already in place. While I did not get much context from previous PRs because there wasn't much and I wasn't around as much to see what were the changes for, I'm also testing style changes and would like to minimize disruption but also allow flexibility to upgrade as needed.

@nebula-aac
Copy link
Contributor Author

nebula-aac commented Apr 27, 2024

I would like to try and streamline the palette so that it will not cause us to backtrack on something that we may have missed.

When I was testing in the video, this is me removing the global css and removing others that were hiding the styles. While I did not use your approach to change the variables or imports to using a new palette object specific to the project, I did see many blank components which means they needed to be updated according to use the new options from the default palette here in Sistent.

@nebula-aac nebula-aac marked this pull request as ready for review May 3, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add Meshery Cloud UI light palette for backward compatibility
2 participants