Resolve imports with query params #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am wondering if you could make this behavior optional? i.e. user can use config to enable/disable it. |
|
Totally forgot I had this done. I've pushed a change to make this feature optional as it rightly should be 😅 . If this looks good then all it will need is updated documentation and tests |
Updated usage of deprecated `substr` to `substring` Updated some tests to use `path.normalize` for windows support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using vite for some time and I needed to have my web worker properly resolved with eslint. Workers in vite require me to add a
?workerto the end of the import path which breaks this resolver. I made this little change locally and it works great for this use case, so maybe this is something you'd like to include?Let me know what you think.