Support creation of containers and test containers on the global namespace #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lgrossi believe you pushed too many unnecessary files 😅 |
lgrossi
force-pushed
the
lucas/fix-subnamespace-for-default-namespace
branch
2 times, most recently
from
fecb467
to
e5d19f0
Compare
Ops, it was so simple that I did it without checking git diff. Totally forgot about .idea 😅. |
lcobucci
changed the title
lcobucci
force-pushed
the
lucas/fix-subnamespace-for-default-namespace
branch
2 times, most recently
from
179db62
to
e335f06
Compare
lcobucci
approved these changes
Aug 1, 2023
…space When creating a new build configuration without namespace and adding later on a subnamespace to it (e.g. using getTestContainer() will add a subnamespace 'Test') the dumped file will have an invalid namespace '\Test' and that will make the di compiler fail.
Due to unexpected false-positives we will ignore the result Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
lcobucci
force-pushed
the
lucas/fix-subnamespace-for-default-namespace
branch
from
e335f06
to
a833621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new build configuration without a namespace and adding later on a subnamespace to it (e.g. using getTestContainer() will add a subnamespace 'Test') the dumped file will have an invalid namespace '\Test' and that will make the di compiler fail.