Progress on supporting IPv6 #805
Conversation
| if (addr.family === 'IPv6' || addr.family === 6) { | ||
| host = '[' + this.host + ']' | ||
| } |
There was a problem hiding this comment.
We need a test to check for IPv6 connectivity. Since we don't yet have v18 in the testing matrix, we don't need to cover the branch. I don't want to add v18 to the testing matrix until I can cut the next major release.
There was a problem hiding this comment.
@MaxLeiter are you able to add this test?
There was a problem hiding this comment.
Yeah sorry, I misunderstood what you meant by “dont need to cover this test”
There was a problem hiding this comment.
Test pushed. Lmk if that's what you meant.
There was a problem hiding this comment.
Suites: 54 passed, 54 of 54 completed
Asserts: 2782 passed, of 2782
Co-authored-by: James Sumners <james@sumners.email>
|
Marking this as ready as tests pass locally |
It is missing the test requested in #805 (comment) |
|
Please include a minimal reproducible example |
Resolves #804