Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Helper to create content data for kolibri tests #11859

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jredrejo
Copy link
Member

Summary

  • Refactors some kolibri code to extract ChannelBuilder to an standalone file

References

Relates: https://github.com/learningequality/kolibri-data-portal/issues/630

Reviewer guidance

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added the work-in-progress Not ready for review label Feb 12, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: medium labels Feb 12, 2024
@jredrejo jredrejo changed the title ]WIP] Helper to create content data for kolibri tests [WIP] Helper to create content data for kolibri tests Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: large SIZE: medium work-in-progress Not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants