New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle session timeout during Quiz Creation in Coach #11875
base: develop
Are you sure you want to change the base?
fix: Handle session timeout during Quiz Creation in Coach #11875
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @GarvitSinghal47 - this is a much better user experience when timing out.
I am not well-versed- still learning about this. @rtibbles can you help and give a final look and we it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of issues with the current approach, and I think it might be neater to use the existing permissions tracking components for this.
@@ -83,6 +83,18 @@ class CoachToolsModule extends KolibriApp { | |||
} else { | |||
next(); | |||
} | |||
|
|||
if (!this.store.getters.isUserLoggedIn) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, it might be worth investigating the withAuthMessage
component defined here:
export default function withAuthMessage(component, authorizedRole) { |
This particular implementation will kind of work, although I am fairly sure the next
query parameter will be lost during the redirect to the auth page.
It is also possible for Kolibri to be configured to redirect unauthenticated users to the Learn page, so in that case, this redirect will not prompt someone to login.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GarvitSinghal47 -- would you be able to revise this PR according to the feedback above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nucleogenesis , my apologies for the oversight. I completely forgot about this open pull request. I will make the necessary adjustments and provide the updates promptly.
@rtibbles, I attempted something and am simply seeking clarification: Is the video below the desired output we're aiming for? User.Sign.In.-.Kolibri.mp4 |
Yes, that looks like the same sort of pattern as we have used elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GarvitSinghal47 - did something get lost in a merge or something? Seems there is only a single small change here.
Fixes #11773
Summary
…
References
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)