New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With 2.7 dropped, use shutil disk_usage function universally. #12041
base: develop
Are you sure you want to change the base?
Conversation
Build Artifacts
|
Hi @rtibbles - the app force closes immediately after launch on all of my devices. Here are the logs, db and logcat from Android studio: |
I guess that takes the uncertainty out of this!
|
Looking at the logs, this is the same error you saw on my PR: #11974 - and doesn't seem to be directly related to this PR at all. |
I will come back to this PR when the other one has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loving when a pr mostly removes code. It's pretty clear (as far as we're using at least python 3.3, which will be the case in develop)
This might need a rebase, since #11974 has been merged... 🤔 |
70fb3a1
to
23decba
Compare
Have rebased on latest develop, so hopefully any errors should be purely its own! |
The only possible source of breakage would be the free space being misreported during resource import. |
Summary
Removes platform specific behaviour.
Uses shutil disk_usage which has support on Unix systems and Windows.
This may well break Android, as it removes the Android specific code, but this will be rectified in the Android installer with this issue: learningequality/kolibri-installer-android#211
References
Fixes the Kolibri side of learningequality/kolibri-installer-android#211
Reviewer guidance
Windows and Unix systems should show free space appropriately for content imports.
Opening as a draft to first confirm the impact on the Android installer.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)