Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align metadata dropdown order to the figma spec #12161

Merged

Conversation

marcellamaki
Copy link
Member

Summary

The list order for the accessibility, and (perhaps more relevantly) grade/level dropdown filters had never been implemented to spec. This creates a helper function to

References

Fixes #12057

before after reference
image Screenshot 2024-05-09 at 3 49 23 PM image
image Screenshot 2024-05-09 at 3 49 06 PM image

Reviewer guidance

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

…array for correct dropdown order, and use this function in the grade levels and accessiblity options dropdown menu creation
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: small labels May 11, 2024
@marcellamaki marcellamaki marked this pull request as ready for review May 13, 2024 12:40
@marcellamaki
Copy link
Member Author

@pcenov @radinamatic this is ready for manual QA. please let me know if you need any additional details

@marcellamaki marcellamaki changed the base branch from develop to release-v0.16.x May 13, 2024 22:41
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, manual QA for merge!

@pcenov
Copy link
Member

pcenov commented May 14, 2024

Hi @marcellamaki - LGTM - here's what I am seeing for both Level and Accessibility (having selected all possible options when I created the resources in Studio):

2024-05-14_11-30-31

A note that in the Accessibility drop-down some of the options are always displayed truncated with ellipsis while in the spec the text goes on the next line.

Also on closer inspection I noticed that in all browsers the descenders of the letters (specifically the 'g's) are not fully visible - wondering whether that warrants filing a separate issue?

@marcellamaki
Copy link
Member Author

Yes, @pcenov if you could file a follow up that includes both of those points, that would be fantastic! thank you

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up issues for non-regressions filed, this can is good to go! 👏🏽 💯 :shipit:

@marcellamaki marcellamaki merged commit 3d44bd9 into learningequality:release-v0.16.x May 14, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: small
Projects
None yet
4 participants