-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path fix for node-js on Ubuntu (or Debian in general?) #3777
Path fix for node-js on Ubuntu (or Debian in general?) #3777
Conversation
@@ -9,7 +9,20 @@ module.exports = function() { | |||
var webpack_json_tempfile = temp.openSync({ suffix: '.json' }).path; | |||
|
|||
// Run the script below to extract the relevant information about the plugin configuration from the Python code. | |||
execSync(`python ${webpack_json} --output_file ${webpack_json_tempfile}`); | |||
// execSync(`python ${webpack_json} --output_file ${webpack_json_tempfile}`); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
My guess is this is caused by yarnpkg/yarn#5874 One person writes:
|
Codecov Report
@@ Coverage Diff @@
## develop #3777 +/- ##
===========================================
- Coverage 50.24% 50.23% -0.01%
===========================================
Files 593 593
Lines 19829 19831 +2
Branches 2476 2477 +1
===========================================
Hits 9963 9963
- Misses 9319 9321 +2
Partials 547 547
Continue to review full report at Codecov.
|
That sounds like the right upstream cause! Thanks for finding it @indirectlylit ! I'll remain subscribed to the issue in order to revert these changes once fixed! |
cool. mind updating the "for reasons unknown" comment? |
e1f29c1
to
fcb223b
Compare
Sure, done! |
Summary
This was previously attempted in #1688 but I found a Node 6 upgrade fixed the issue back then.
However, now on Ubuntu 18.04, I find the issue occurring with the current official Debian pkg for Node.
@rtibbles does this work on your system as well?
If this get's merged, I'm fine that it get's quickly reverted if fellow devs report issues with it.
Reviewer guidance
@rtibbles we've been here before...
References
#1688
Contributor Checklist
Reviewer Checklist
yarn
andpip
)