Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes path manipulation workaround. Please see https://github.com/yarnpkg/yarn/issues/5874 #9805

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

akolson
Copy link
Member

@akolson akolson commented Oct 31, 2022

Summary

This pr removes manipulation of $PATH, a workaround used in previous versions of yarn. This seems to have been fixed as indicated in yarnpkg/yarn#5874

References

NA

Reviewer guidance

Set up the development environment as specified in https://kolibri-dev.readthedocs.io/en/develop/getting_started.html should result in successfully running kolibri locally without returning build errors


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson added the TODO: needs review Waiting for review label Oct 31, 2022
@akolson akolson changed the title Removes path manipulation workaround. Please see https://github.com/y… Removes path manipulation workaround. Please see https://github.com/yarnpkg/yarn/issues/5874 Oct 31, 2022
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct, local testing checks out.

@rtibbles rtibbles merged commit 8b52ea2 into learningequality:develop Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants