Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eip-3074 implementation #10154

Closed
wants to merge 9 commits into from
Closed

eip-3074 implementation #10154

wants to merge 9 commits into from

Conversation

sudeepdino008
Copy link
Contributor

@sudeepdino008 sudeepdino008 commented May 1, 2024

reference: https://eips.ethereum.org/EIPS/eip-3074

Checklist:

  • AUTH implementation
  • AUTHCALL implementation
  • unit tests added
  • CI passing?

@sudeepdino008
Copy link
Contributor Author

sudeepdino008 commented May 6, 2024

@somnathb1 b41f30f I had added CALLCODE in the condition because it should be there (value transfer block).

I had to remove/revert it because the integration tests are failing. Before I go to fix them, wanted to make sure if this is expected (if CALLCODE should be part of that condition)

But shouldn't CALLCODE be part of that condition? (even though it's deprecated now).

@sudeepdino008 sudeepdino008 force-pushed the su/eip3074 branch 2 times, most recently from 0fe8a19 to c53deb3 Compare May 10, 2024 05:53
- unit test imported from ethereum/go-ethereum#28615
- the invoker contract needed to be modified a little (use PUSH0 instead of
  GAS), so as to allow all gas to be available for the invoked contract.
- fix for AUTHCALL constant gas to include warm storage access cost.
@sudeepdino008 sudeepdino008 marked this pull request as ready for review May 10, 2024 09:54
@sudeepdino008 sudeepdino008 marked this pull request as draft May 10, 2024 10:40
@yperbasis
Copy link
Collaborator

At the ACD on 23 May it was decided that EIP-7702 will be in Pectra instead of EIP-3074.

@yperbasis yperbasis closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pectra The Prague/Electra protocol upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants