Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polygon/heimdall: database #10377

Merged
merged 2 commits into from
May 21, 2024
Merged

polygon/heimdall: database #10377

merged 2 commits into from
May 21, 2024

Conversation

battlmonstr
Copy link
Collaborator

Create a separate mdbx database in <datadir>/heimdall.
Rewrite entityStore to use it.

taratorio
taratorio reviewed May 20, 2024
View reviewed changes
eth/backend.go Outdated Show resolved Hide resolved
taratorio
taratorio reviewed May 20, 2024
View reviewed changes
eth/backend.go Outdated Show resolved Hide resolved
taratorio
taratorio requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@taratorio taratorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs more work to avoid passing in DB dependencies to heimdall component
logic should be encapsulated within heimdall

@battlmonstr
polygon/heimdall: database
5dce0a8
@battlmonstr
fixes
28c6e89 
* don't use node.OpenDatabase
* add HeimdallDB label
* init tables
@taratorio taratorio merged commit 4cae699 into main May 21, 2024
10 checks passed
@taratorio taratorio deleted the pr/hddb branch May 21, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taratorio taratorio taratorio approved these changes

Assignees
No one assigned
Labels
polygon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@battlmonstr @taratorio