erigon-lib/state: inverted index to use elias fano reverse iterator seek #10397
+410
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
pushed a commit
that referenced
this pull request
May 18, 2024
- Reduces memory allocations for reverse iterator from 49681997 B/op to 144 B/op - Adds support for reverse binary search Seek to reverse iterator (we can use that in `FrozenInvertedIdxIter.advanceInFiles` for more performance - will add in a subsequent [PR](#10397)) ``` ➜ go test -bench=. -benchmem goos: darwin goarch: arm64 pkg: github.com/ledgerwatch/erigon-lib/recsplit/eliasfano32 BenchmarkName/next_to_value_1_000_000-8 1113 1091076 ns/op 144 B/op 1 allocs/op BenchmarkName/seek_to_value_1_000_000-8 2000680 601.1 ns/op 144 B/op 1 allocs/op BenchmarkName/reverse_next_to_value_1_230-8 8 129665120 ns/op 152 B/op 2 allocs/op BenchmarkName/reverse_seek_to_value_1_230-8 1000000 1062 ns/op 152 B/op 2 allocs/op BenchmarkName/naive_reverse_iterator-8 8 135305406 ns/op 49681997 B/op 42 allocs/op BenchmarkName/reverse_iterator-8 8 127542469 ns/op 144 B/op 1 allocs/op PASS ok github.com/ledgerwatch/erigon-lib/recsplit/eliasfano32 12.937s ```
awskii
approved these changes
May 21, 2024
|
will you take a followup issue on implementing Seek with new descending iterator? |
@awskii I need to play around with unwind first and learn how it works a bit better. |
AskAlexSharov
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pending on #10395
Seek is supported for reverse binary search which is a lot more efficient in to getting to the correct iterator start point than using
it.Nextandcontinue