Improved eth_syncing
#10398
Merged
Improved eth_syncing
#10398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So uum, I also fixed #10307 since I was at it, but forgot to make a new branch :P |
|
@Giulio2002 why updaing this value only in InsertBlocks is not enough? why need update in UFC also? |
Not sure if this is a good heuristics, I thought that perhaps on other chains, one day old blocks might get imported too? I am just not sure what we need in the future and at first glance ValidateChain and Forkchoice sounded like better candidates because they MUST be called near chain tip |
awskii
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach is simple, every time the
Executionmodule sees a block it saves the number in DB. That number is the heuristics for the "tip of the chain".Also changes from stages.Finish to stages.Execution. the issue was that for syncing up everything (stages.Headers as well) is in a single mdbx tx. Now we have separate key which is committed in a small
Updatebefore the processing.