Add setting for filtering empty containers on Prometheus queries #7777
+46
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juho Heikka <juho.heikka@gmail.com>
jweak
requested review from
ixrock,
jim-docker and
a team
and removed request for
a team
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Can this PR get merged? |
|
Any progress? Would be great to get it into the next release. |
|
@jweak please resolve the conflicts, community really need this |
|
@jim-docker @ixrock please review this PR |
|
Hi! There is any update on this please? |
|
It appears that this repo is no longer maintained. |
|
very sad to see that this project is dead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a setting for applying the old Prometheus queries which were changed in this PR #6679
This change made it so that some setups are observing metrics as doubled.
container!=""does filter those values.We have this change only for operator provider since it's the only one that had that change. We'll show the setting for Auto Detect or Operator values since those are the ones that could lead into using the operator Prometheus provider.
#7299