Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding table package with injection tokens #7818

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Adding table package with injection tokens #7818

wants to merge 26 commits into from

Conversation

aleksfront
Copy link
Contributor

@aleksfront aleksfront commented Jun 1, 2023 •
edited

Replacing #7754

  1. Adding tokens:
  • tableComponentInjectionToken
  • addOrRemoveButtonsInjectionToken
  • createTableStateInjectionToken
  1. Adding injectables in open-lens utilizing them.

@aleksfront
Add table and add-remove buttons injection tokens
007a017 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Add table package.json
471a515 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Add table package tsconfig and webpack.config
6e6e540 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Add simple README
547722f 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Bump @ogre-tools/injectable version
a2cd784 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Use table from injection token
f9978f3 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Using AddOrRemoveButtons component from injection token
c48b88e 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Creating tableComponentInjectable in open-lens
60c4391 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Adding addRemoveButtonsInjectable
c7f4d1c 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Adding @k8slens/table as dependencies to core and open-lens
9aae3ff 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Create injectables in test-env also
1855b2a 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Remove "dev" command
4173225 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Linter fixes
0f41556 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront added this to the 6.6.0 milestone Jun 1, 2023
@aleksfront aleksfront requested a review from ixrock June 1, 2023 11:11
@aleksfront aleksfront requested a review from a team as a code owner June 1, 2023 11:11
@aleksfront aleksfront requested review from jim-docker and removed request for a team June 1, 2023 11:11
@aleksfront
Adding createTableStateInjectionToken
2a629ff 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Update package-lock.json
365cf5c 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Add linkable command to core package
71ebf6e 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Adding tableStateInjectable and context
da3946b 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Using tableStateInjectable in content.tsx
4fa2cce 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Adding createTableStateInjectable
e4c4f54 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Linter fixes
0ac0157 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Merge branch 'master' into add-table-package
c57c236
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ixrock
Merge remote-tracking branch 'origin/master' into add-table-package
d4edddf 
# Conflicts:
#	packages/core/src/renderer/components/item-object-list/content.tsx
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@aleksfront
Remove unused dev dependency from core
fc22241 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Changing paths for test-env injectables
3b17490 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Adding TableDataColumn and TableDataRow types
ddc1048 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Adding create-table-state.injectable.ts into test-env folder
67370c1 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
ixrock reviewed Jun 6, 2023
View reviewed changes
packages/core/src/renderer/components/table/table-state.injectable.tsx
({ id: columnId, className, title }, index) => ({
id: columnId ?? className,
className,
resizable: !!columnId,
sortable: !!columnId,
draggable: !!columnId, // e.g. warning-icon column in pods
title,
renderValue(row: any, col: any) {
renderValue(row: TableDataRow) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be TableDataRow<K> otherwise you'll loose row.data typing (if provided in createLensTableState()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixrock ixrock ixrock left review comments

@jim-docker jim-docker Awaiting requested review from jim-docker jim-docker is a code owner automatically assigned from lensapp/lens-ide

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aleksfront @ixrock