Fix broken require of .remarkrc.js #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the plugin errors if you create a '.remarkrc.js' file: `Cannot find module './.remarkrc.js'` The issue is that `require` resolves relative to the current file, while `fs.exists` resolves relative to cwd. The `require` wasn't reading the same path as the `fs.exists`, instead it was trying to read the file relative to this file i.e. `./node_modules/eslint-plugin-md/lib/rules/.remarkrc.js`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the plugin errors if you create a '.remarkrc.js' file:
Cannot find module './.remarkrc.js'The issue is that
requireresolves relative to the current file, whilefs.existsresolves relative to cwd. Therequirewasn't reading the same path as thefs.exists, instead it was trying to read the file relative to this file i.e../node_modules/eslint-plugin-md/lib/rules/.remarkrc.js.