Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for indented code blocks. #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

scinos
Copy link

@scinos scinos commented Sep 21, 2020

Changes

  • Adds support for indented code blocks.
  • Added tests
  • Simplify JS block "extraction" to avoid adding extra lines

Fixes #7

@scinos
Copy link
Author

scinos commented Oct 5, 2020

@leo-buneev any update on this?

@leo-buneev
Copy link
Owner

leo-buneev commented Oct 5, 2020

Sorry for delay, and thanks for great work :)
will merge after I'll return from vacation, sometime this week. Let me know if you need it more urgently.

@scinos
Copy link
Author

scinos commented Nov 22, 2020

Friendly reminder that this PR is still open.

I just got hit by the bug it solves today :)

@scinos
Copy link
Author

scinos commented Jan 11, 2021

Friendly reminder that this PR is still open.

I'm very interested about this plugin and it has become part of my recommended setup when using eslint (in fact I wrote about it in https://blog.frontendops.dev/2020/11/24/eslint-for-markdown/). Please let me know if you need help maintaining it, as I would love to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Doesn't parse indented code blocks
2 participants