Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services): run npm install + build #16

Merged
merged 1 commit into from May 25, 2021
Merged

feat(services): run npm install + build #16

merged 1 commit into from May 25, 2021

Conversation

theoludwig
Copy link
Member

@theoludwig theoludwig commented May 17, 2021 •
edited

What changes this PR introduce?

Add the install and build methods for the LeonInstance class, to do npm install and npm run build when creating a new instance.

Is there anything you'd like reviewers to focus on?

  • How can I write automated tests for that ? It will probably be tested thanks to e2e tests that we will do later, but I don't know if it is possible to write unit tests for that.

@theoludwig theoludwig added the feature request Suggest a new feature idea label May 17, 2021
@theoludwig theoludwig self-assigned this May 17, 2021
@theoludwig theoludwig force-pushed the feat/npm-install-build branch 2 times, most recently from be9c79c to b7f3a02 Compare May 18, 2021 08:31
ArthurDelamare
ArthurDelamare approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@ArthurDelamare ArthurDelamare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me !

@theoludwig theoludwig merged commit fa0d409 into develop May 25, 2021
@theoludwig theoludwig deleted the feat/npm-install-build branch May 25, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurDelamare ArthurDelamare ArthurDelamare approved these changes

Assignees

@theoludwig theoludwig

Labels
feature request Suggest a new feature idea
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theoludwig @ArthurDelamare