Add compile error when using comment and doctype tags within the view! macro
#2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just for consistency. `proc_macro_error::emit_error` is always called in the qualified form, but `proc_macro_error::abort!` was sometimes called in the non-qualified form, which was made possible by `#[macro_use] external crate proc_macro_error`.
Currently, these tags are not displayed in the rendered view. Instead of silently doing so, this change introduces a compile error with a helpful message.
|
Thanks. This is somewhat awkward as it's a breaking change. I think the Maybe just change it for DOCTYPE, or we can just wait? |
Emit compile-time warnings instead of errors when using doctype and comment tags within `view!` macro.
|
I've changed the compile-time errors to warnings: Up to you if you want to leave this change alone and just wait for the next major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #2338.
Preview of the error messages:
The first commit contains just style changes (using
proc_macro_error::abort!everywhere instead of justabort!, to be consistent withproc_macro_error::emit_error!), so it can be reverted if desired.