fix: StoredValue and Resource panic during cleanup #2583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the value inside a
StoredValue
implements the drop trait, and that drop causes another read, update or dispose on another StoredValue, we'd get a cryptic panic withalready mutably borrowed: BorrowError
.I encountered this issue with a
StoredValue<Disposer>
with the disposer type returned byas_child_of_current_owner()
. Because the Disposer cleans up a reactive sub-scope on Drop, it will try to mutably borrowRuntime::stored_values
while it is still mutably borrowed by the function that drops it.