Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): --sync-workspace-lock flag no longer work because of pnpm regression #233

Merged
merged 4 commits into from Jun 29, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Jun 28, 2022

Description

Last version of pnpm v7.4.0 has a change to exit early on install --lockfile-only and that is impacting (aka failing) the version unit tests which use pnpm, it seems to be exiting too early and skipping the lock file update which defeat the purpose of the --sync-workspace-lock flag.

Adding --fix-lockfile to pnpm seems to be help to get previous pnpm behavior. I wish that --lockfile-only would still work but the --fix-lockfile flag is a quick fix for now until pnpm addresses this regression issue that I opened in the pnpm project.

# adding the fix extra flag helps get previous pnpm behavior
pnpm install --lockfile-only --fix-lockfile

quick (patch) fix for issue #234

Motivation and Context

re-enable previously failing unit tests with pnpm and find a way to bypass new pnpm regression caused in latest pnpm 7.4.0

How Has This Been Tested?

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #233 (95fff96) into main (ec19b73) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   93.11%   93.21%   +0.11%     
==========================================
  Files         134      134              
  Lines        3972     3972              
  Branches      805      805              
==========================================
+ Hits         3698     3702       +4     
+ Misses        274      270       -4     
Impacted Files Coverage Δ
...ackages/version/src/lib/update-lockfile-version.ts 100.00% <100.00%> (ø)
packages/version/src/version-command.ts 99.73% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec19b73...95fff96. Read the comment docs.

@ghiscoding ghiscoding changed the title tests: re-enable version unit tests with pnpm fix(version): --sync-workspace-lock flag no longer work because of pnpm regression Jun 29, 2022
@ghiscoding ghiscoding merged commit 414921d into main Jun 29, 2022
@ghiscoding ghiscoding deleted the bugfix/version-unit-test branch June 29, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant