Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): use --no-frozen-lockfile instead of --fix-lockfile, fixes #234 #236

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Jun 30, 2022

Description

to fix a regression or a change in behavior with pnpm 7.4.0, the pnpm maintainer is suggesting to use pnpm i --lockfile-only --no-frozen-lockfile instead of --fix-lockfile

Motivation and Context

possible fix for issue #234

How Has This Been Tested?

Types of changes

  • Chore (refactoring/non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- to fix a regression or a change in behavior with pnpm 7.4.0, the pnpm maintainer is suggesting to use `pnpm i --lockfile-only --no-frozen-lockfile`  instead of `--fix-lockfile`
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #236 (a6120b9) into main (9f1ad41) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files         137      137           
  Lines        4012     4012           
  Branches      821      821           
=======================================
  Hits         3759     3759           
  Misses        253      253           
Impacted Files Coverage Δ
...ackages/version/src/lib/update-lockfile-version.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1ad41...a6120b9. Read the comment docs.

@ghiscoding ghiscoding changed the title fix(version): use --no-frozen-lockfile instead of --fix-lockfile fix(version): use --no-frozen-lockfile instead of --fix-lockfile, fixes #234 Jun 30, 2022
@ghiscoding ghiscoding merged commit e032e66 into main Jun 30, 2022
@ghiscoding ghiscoding deleted the bugfix/lockfile-no-frozen-lockfile branch June 30, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant