Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): exclude dependencies with --scope when nx.json is not present #336

Merged
merged 1 commit into from Sep 13, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Sep 13, 2022

Description

As per Lerna PR

When nx.json is not present, packages being run will no longer include their dependencies when those dependencies would be filtered out by --scope. Using the flag --include-dependencies will cause them to be included again, as expected.

Motivation and Context

As per Lerna PR 3316

This preserves the default behavior of lerna run --scope when useNx is true and nx.json does not exist.

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #336 (3c222ed) into main (f269d5e) will decrease coverage by 0.02%.
The diff coverage is 91.67%.

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   96.14%   96.12%   -0.01%     
==========================================
  Files         145      145              
  Lines        4242     4252      +10     
  Branches      892      895       +3     
==========================================
+ Hits         4078     4087       +9     
- Misses        164      165       +1     
Impacted Files Coverage Δ
packages/cli/src/cli-commands/cli-run-commands.ts 100.00% <ø> (ø)
packages/run/src/run-command.ts 95.00% <90.00%> (-0.34%) ⬇️
packages/core/src/command.ts 94.12% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 0900f96 into main Sep 13, 2022
@ghiscoding ghiscoding deleted the bugfix/lerna-run-exclude-deps branch September 13, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant