Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): allow for loading of env files to be skipped #391

Merged
merged 1 commit into from Oct 14, 2022

Conversation

ghiscoding
Copy link
Member

Description

As per Lerna 3375

Makes one subcomponent of the change of default task runner more explicit, namely the automatic loading of .env files.
Also adds a flag to allow users to disable this behavior if they wish (added as a fix because it was an oversight for the v6 release)

Motivation and Context

keep in sync with Lerna

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #391 (7297c64) into main (c585090) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   97.31%   97.31%   +0.01%     
==========================================
  Files         146      146              
  Lines        4334     4335       +1     
  Branches     1003     1004       +1     
==========================================
+ Hits         4217     4218       +1     
  Misses        117      117              
Impacted Files Coverage Δ
packages/cli/src/cli-commands/cli-run-commands.ts 100.00% <ø> (ø)
packages/run/src/run-command.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 440611e into main Oct 14, 2022
@ghiscoding ghiscoding deleted the bugfix/run-load-env-files branch October 14, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant