Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support changelog-presets using async factory funcs #766

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Nov 19, 2023

Description

Support newer version of conventional-changelog-conventionalcommits

Motivation and Context

As per Lerna PR 3873](lerna/lerna#3873)

new 7.x.x versions of conventional changelog presets use async factory functions createPreset (see conventional-changelog/conventional-changelog#1045)

Fixes

Using conventionalcommits as changelogPreset causes lerna version to do nothing

{
  "changelogPreset": "conventional-changelog-conventionalcommits"
}

Up until the v7 release of conventional-changelog, this worked as expected. After upgrading to v7+, the lerna version process exits immediately (with zero exit code) after loading the conventionalcommits package, rather than proceeding with the versioning process.

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2709896) 98.12% compared to head (36d4ef3) 98.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
+ Coverage   98.12%   98.12%   +0.01%     
==========================================
  Files         154      154              
  Lines       11644    11647       +3     
  Branches     1918     1920       +2     
==========================================
+ Hits        11425    11428       +3     
  Misses        218      218              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 77c293f into main Nov 19, 2023
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/fix-changelog-preset branch November 19, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant