feat(has-npm-version): Remove unused makePredicate() export

BREAKING CHANGE: The makePredicate() export has been removed, memoization is now the responsibility of the caller.

commands/__mocks__/@lerna/has-npm-version.js

@@ -1,7 +1,5 @@
 "use strict";
 
 const mockHasNpmVersion = jest.fn(() => true);
-const mockMakePredicate = jest.fn(() => (range) => mockHasNpmVersion(range));
 
 module.exports.hasNpmVersion = mockHasNpmVersion;
-module.exports.makePredicate = mockMakePredicate;

utils/has-npm-version/__tests__/has-npm-version.test.js

@@ -3,7 +3,7 @@
 jest.mock("@lerna/child-process");
 
 const childProcess = require("@lerna/child-process");
-const { hasNpmVersion, makePredicate } = require("../lib/has-npm-version");
+const { hasNpmVersion } = require("../lib/has-npm-version");
 
 childProcess.execSync.mockReturnValue("5.6.0");
 
@@ -13,13 +13,3 @@ test("hasNpmVersion() returns boolean if range is satisfied by npm --version", (
 
   expect(childProcess.execSync).toHaveBeenLastCalledWith("npm", ["--version"]);
 });
-
-test("makePredicate() returns a predicate with cached version", () => {
-  const predicate = makePredicate();
-
-  childProcess.execSync.mockReturnValue("3.10.10");
-
-  // the predicate has cached the initial version, not the new version
-  expect(predicate(">=5")).toBe(true);
-  expect(hasNpmVersion(">=5")).toBe(false);
-});

utils/has-npm-version/lib/has-npm-version.js

@@ -4,18 +4,11 @@ const semver = require("semver");
 const childProcess = require("@lerna/child-process");
 
 module.exports.hasNpmVersion = hasNpmVersion;
-module.exports.makePredicate = makePredicate;
 
 function hasNpmVersion(range) {
   return rangeSatisfies(getNpmVersion(), range);
 }
 
-function makePredicate() {
-  const npmVersion = getNpmVersion();
-
-  return (range) => rangeSatisfies(npmVersion, range);
-}
-
 function rangeSatisfies(npmVersion, range) {
   return Boolean(semver.satisfies(npmVersion, range));
 }