Fix bootstrap install to use quotes around versions (#235)

* Fix bootstrap install to use quotes around versions * Address PR feedback
lerna · Jun 20, 2016 · c0f1e8d · c0f1e8d
1 parent 02ffb96
commit c0f1e8d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/commands/BootstrapCommand.js b/src/commands/BootstrapCommand.js
@@ -109,7 +109,8 @@ export default class BootstrapCommand extends Command {
         return !this.hasDependencyInstalled(pkg, dependency);
       })
       .map(dependency => {
-        return dependency + "@" + allDependencies[dependency];
+        // Needs "quotes" for versions like "^1.0.0 || ^2.0.0"
+        return `${dependency}@"${allDependencies[dependency]}"`;
       });
 
     if (externalPackages.length) {

diff --git a/test/BootstrapCommand.js b/test/BootstrapCommand.js
@@ -28,7 +28,7 @@ describe("BootstrapCommand", () => {
 
       assertStubbedCalls([
         [ChildProcessUtilities, "spawn", { nodeCallback: true }, [
-          { args: ["npm", ["install", "package-1@^0.0.0"], { cwd: path.join(testDir, "packages/package-4"), stdio: "ignore" }] }
+          { args: ["npm", ["install", "package-1@\"^0.0.0\""], { cwd: path.join(testDir, "packages/package-4"), stdio: "ignore" }] }
         ]]
       ]);
 
@@ -77,7 +77,7 @@ describe("BootstrapCommand", () => {
 
       assertStubbedCalls([
         [ChildProcessUtilities, "spawn", { nodeCallback: true }, [
-          { args: ["npm", ["install", "package-1@^0.0.0"], { cwd: path.join(testDir, "packages/package-4"), stdio: "ignore" }] }
+          { args: ["npm", ["install", "package-1@\"^0.0.0\""], { cwd: path.join(testDir, "packages/package-4"), stdio: "ignore" }] }
         ]]
       ]);
 
@@ -131,7 +131,7 @@ describe("BootstrapCommand", () => {
 
       let installed = false;
       stub(ChildProcessUtilities, "spawn", (command, args, options, callback) => {
-        assert.deepEqual(args, ["install", "external@^1.0.0"])
+        assert.deepEqual(args, ["install", "external@\"^1.0.0\""])
         assert.deepEqual(options, { cwd: path.join(testDir, "packages/package-1"), stdio: "ignore" })
         installed = true;
         callback();