fix(version): create release when using custom tag-version-separator (#…

…3979)
lerna · Apr 1, 2024 · cbe01ba · cbe01ba
1 parent 0cbf857
commit cbe01ba
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/libs/commands/version/src/index.ts b/libs/commands/version/src/index.ts
@@ -389,7 +389,11 @@ class VersionCommand extends Command {
       tasks.push(() =>
         createRelease(
           this.releaseClient,
-          { tags: this.tags, releaseNotes: this.releaseNotes },
+          {
+            tags: this.tags,
+            tagVersionSeparator: this.options.tagVersionSeparator || "@",
+            releaseNotes: this.releaseNotes,
+          },
           { gitRemote: this.options.gitRemote, execOpts: this.execOpts }
         )
       );

diff --git a/libs/commands/version/src/lib/create-release.ts b/libs/commands/version/src/lib/create-release.ts
@@ -16,21 +16,26 @@ export function createReleaseClient(type: "github" | "gitlab") {
 
 export function createRelease(
   client: ReturnType<typeof createReleaseClient>,
-  { tags, releaseNotes }: { tags: string[]; releaseNotes: { name: string; notes: string }[] },
+  {
+    tags,
+    releaseNotes,
+    tagVersionSeparator,
+  }: { tags: string[]; tagVersionSeparator: string; releaseNotes: { name: string; notes: string }[] },
   { gitRemote, execOpts }: { gitRemote: string; execOpts: ExecOptions }
 ) {
   const repo = parseGitRepo(gitRemote, execOpts);
 
   return Promise.all(
     releaseNotes.map(({ notes, name }) => {
-      const tag = name === "fixed" ? tags[0] : tags.find((t) => t.startsWith(`${name}@`));
+      const tag =
+        name === "fixed" ? tags[0] : tags.find((t) => t.startsWith(`${name}${tagVersionSeparator}`));
 
       /* istanbul ignore if */
       if (!tag) {
         return Promise.resolve();
       }
 
-      const prereleaseParts = semver.prerelease(tag.replace(`${name}@`, "")) || [];
+      const prereleaseParts = semver.prerelease(tag.replace(`${name}${tagVersionSeparator}`, "")) || [];
 
       return client.repos.createRelease({
         owner: repo.owner,