Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): Exclude dependencies with --scope when nx.json is not present #3316

Merged
merged 5 commits into from Sep 9, 2022

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Sep 2, 2022

When nx.json is not present, packages being run will no longer include their dependencies when those dependencies would be filtered out by --scope. Using the flag --include-dependencies will cause them to be included again, as expected.

Description

This preserves the default behavior of lerna run --scope when useNx is true and nx.json does not exist.

Motivation and Context

#3289
#3298

How Has This Been Tested?

End to end tests have been added that cover this behavior. The functionality was also manually tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review September 2, 2022 17:11
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion about verbose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants