Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(describe-ref): add --tags arg to git describe #1778

Closed
wants to merge 2 commits into from

Conversation

Hoishin
Copy link

@Hoishin Hoishin commented Nov 13, 2018

Description

Run git describe with --tags arg to ensure it shows the most recent tag in history.

Motivation and Context

When you manually put tags, but want the manual tags to be referenced in lerna version, this change is required.
More information about annotated tags and unannotated tags

Fixes #1357

How Has This Been Tested?

Changed locally installed lerna and confirmed that it shows the correct packages to version-up.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (Don't think I have to)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evocateur
Copy link
Member

From the git-tag docs:

Annotated tags are meant for release while lightweight tags are meant for private or temporary object labels. For this reason, some git commands for naming objects (like git describe) will ignore lightweight tags by default.

Lerna uses annotated tags when versioning, uses git describe when determining previous releases, and neither of those will change.

Manual version tagging, if you need it, need only include a -m argument to remain compatible.

@evocateur evocateur closed this Nov 23, 2018
@Hoishin Hoishin deleted the git-desc-tag branch December 13, 2018 09:42
@lock
Copy link

lock bot commented Feb 11, 2019

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lerna will always publish all packages even if some are not changed
2 participants