Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(link): generate shims for missing 'bin' scripts #2059

Merged
merged 2 commits into from May 11, 2019
Merged

feat(link): generate shims for missing 'bin' scripts #2059

merged 2 commits into from May 11, 2019

Commits on Apr 26, 2019

  1. feat(link): generate shims for missing 'bin' scripts

    During the 'link' step, if a package's binary targets don't exist yet
    they will fail to be symlinked, even if a later `run xxx` step would
    have generated them. This is a situation that occurs in monorepos
    containing build tools compiled from another language (e.g. TypeScript).
    
    Simply adding the symlinks whether the target exists or not is not good
    enough, as the symlink target needs to be `chmod +x`ed, which is
    lerna's/npm's responsibility.
    
    Instead, if the target doesn't exist, generate a shim shell script that
    will `chmod` and `exec` the intended target, similar to what would
    happen on Windows normally.
    
    Fixes #1444.
    Rico Huijbers committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    8816a19 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. Fix unit tests

    rix0rrr committed May 4, 2019
    Configuration menu
    Copy the full SHA
    e24fd3b View commit details
    Browse the repository at this point in the history