feat(bootstrap): Allow to specify custom folder for packages symlinks #2081
Conversation
There was a problem hiding this comment.
Literally no tests added, not going to be accepted without them.
I'm unclear what problem this solves, aside from promoting dubious patterns like deeply-nested subpath imports (they should be exported from the module entry or factored into separate packages).
| @@ -53,6 +53,9 @@ class Package { | |||
| rootPath: { | |||
| value: rootPath, | |||
| }, | |||
| symLinkDir: { | |||
There was a problem hiding this comment.
symlinkDir, if you must. We don't call symlinks "sym-links", after all.
| @@ -53,6 +53,9 @@ class Package { | |||
| rootPath: { | |||
| value: rootPath, | |||
| }, | |||
| symLinkDir: { | |||
| value: pkg.symLinkDir, | |||
There was a problem hiding this comment.
Can you point me to an example of any other usage in the ecosystem? I don't want to add arbitrary fields to package.json just to satisfy a vanishingly small percentage of use cases.
| @@ -77,7 +77,10 @@ function symlinkDependencies(packages, packageGraph, tracker) { | |||
| }); | |||
|
|
|||
| // create package symlink | |||
| chain = chain.then(() => createSymlink(dependencyNode.location, targetDirectory, "junction")); | |||
| const dependencyLocation = dependencyNode.pkg.symLinkDir | |||
| ? path.resolve(dependencyNode.location, dependencyNode.pkg.symLinkDir) | |||
There was a problem hiding this comment.
Wouldn't this be better served by the lerna bootstrap equivalent of --contents? This smells to high heaven of Angular-isms.
|
Looks like this is halfway there to closing #2209. The In a file within import { MyComponent } from '@org/core-components'This works for a published package but since import { MyComponent } from '@org/core-components/dist'This PR and #2209 would make that workflow much easier. @paul-roman are you planning to add tests/make any additional changes? Otherwise I could possibly take a stab at contributing this. Based on these discussions, what I'm seeing is some other changes:
|
|
I have opened a new PR that continues these changes: #2274 |
|
Closing in favor of #2274 |
Description
This allows to specify a
symLinkDirin a packagepackage.jsonto create the symbolic link from a specific folder of the package.Motivation and Context
This was motivated by the need to access to the folder structure of the transpiled source of one of our packages, thus we needed that only the
distfolder was used in the symbolic link.How Has This Been Tested?
We added a
"symLinkDir": "dist"field in one of our packagespackage.json, we ranlerna bootstrapand used another package which depends on the first one. Only thedistfolder was used for the symbolic link, allowing us to access to the whole folder structure of thedistfolder usingTypes of changes
Checklist: