Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): respect "pkg.publishConfig.directory" #2130

Closed
wants to merge 1 commit into from

Conversation

aleclarson
Copy link

@aleclarson aleclarson commented Jun 10, 2019

This is a quick fix for #2113 (comment)

I assume you'll want to do it a different way :)

Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests is a non-starter. What specific issue does this solve?

@aleclarson
Copy link
Author

Failing tests is a non-starter.

Yeah sorry, I would fix/write tests if I had time.

What specific issue does this solve?

Running lerna publish does not respect pkg.publishConfig.directory when it filters the list of packages by their "privateness". It should be checking the package.json in the publish directory, instead. The package root is marked private to avoid accidental npm publish. When the publish directory has its package.json generated, the private: true field is removed.

@evocateur
Copy link
Member

cc #2113 (comment)

@aleclarson aleclarson closed this Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants