docs: add pull request section to CONTRIBUTING.md #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizel3d
reviewed
Jul 31, 2019
CONTRIBUTING.md
Outdated
|
|
||
| ### Submitting Pull Requests | ||
|
|
||
| If you've cloned the project directly and are working on a feature branch, you'll need write permissions to be able to push that branch to the remote to open a pull request. |
There was a problem hiding this comment.
- This statement is obvious enough.
- I don't see a reason to share write permission with contributors. Fork is only right way.
dizel3d
suggested changes
Jul 31, 2019
evocateur
suggested changes
Aug 2, 2019
|
Sounds good! Thanks @3imed-jaberi @dizel3d @evocateur. I cam amend the PR to encourage forking. |
piperchester
commented
Aug 2, 2019
|
@piperchester you may also add the link to respective github guide |
piperchester
commented
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is something I ran into when beginning work on #2198. I'm happy to update the docs to only allow forking if that's the contribution model we'd rather see here, but wanted to start the discussion.