Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git-add.js #2303

Closed
wants to merge 2 commits into from
Closed

Update git-add.js #2303

wants to merge 2 commits into from

Conversation

rozbo
Copy link

@rozbo rozbo commented Oct 16, 2019

tested this way is the simplest to resolve
#2151
#1075
#2267
#2141
#2113
#1096
#216

etc....

       -u, --update
          Update the index just where it already has an entry matching <pathspec>. This removes as well as modifies index entries to match the working tree, but adds no new files.     
If no <pathspec> is given when -u option is used, all tracked files in the entire working tree are updated (old versions of Git used to limit the update to the current directory and its subdirectories).

It has a flaw in that it cannot track the newly created files, but no new files are created in our scenario, so it is suitable for us.

落月 added 2 commits October 16, 2019 19:00
tested this way is the simplest to resolve 
#2151 
#1075 
#2267 
#2141 
#2113 
#1096 
#216 
etc....
-------
>        -u, --update
>           Update the index just where it already has an entry matching <pathspec>. This removes as well as modifies index entries to match the working tree, but adds no new files.
>
>  If no <pathspec> is given when -u option is used, all tracked files in the entire working tree are updated (old versions of Git used to limit the update to the current directory and its subdirectories).


It has a flaw in that it cannot track the newly created files,  but no new files are created in our scenario, so it is suitable for us.
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how any of the other tickets beyond the first one are related. In any case, you might have noticed from the myriad test failures that it isn't quite this simple. CHANGELOG.md might not exist, after all.

@rozbo
Copy link
Author

rozbo commented Oct 17, 2019

Omm, it's my fault, I didn't look at the pull request notice. I am so sorry!
But as you can see, this case happens when a package to be published is in a .gitignore file. In this case, it should be logical that the check is no longer performed. but the actual situation is no difference to execution git add, this cause the error.
I really think this is a common scenario. For example, in a multi-person development scenario, a local development package doesn't want to be shared with others. At this point, obviously I should put it in gitignore. Another example is a dynamically generated package
the issues above is search the related words , it's scenario is related this problem.
In my point, the most thorough solution is to add an option to completely ignore the packages I don't want to publish, rather than relying on the private option. just like command.bootstrap.ignore.
Anyway, I wish you all the best, thank you for everything you have done!

@evocateur
Copy link
Member

Thanks for understanding.

@evocateur evocateur closed this Oct 18, 2019
@rozbo rozbo deleted the patch-1 branch October 19, 2019 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants