fix(collect-dependents): Avoid skipping dependents of cyclic dependencies #2380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of cyclic dependencies, some packages of the modified package are skipped.
Description
packages:
Let's say we changed
package-cycle-2
then the following will happen:package-cycle-2
is current node. Check local dependents ofpackage-cycle-2
package-cycle-1
package-cycle-1
to changed. Remember that we visit it.package-cycle-1
package-cycle-2
because it is current node. Remember that we visit it.package-cycle-extraneous-1
because local dependents ofpackage-cycle-1
includepackage-cycle-2
. Remember that we visit it.package-cycle-extraneous-2
because local dependents ofpackage-cycle-1
includepackage-cycle-2
. Remember that we visit it.package-cycle-extraneous-2
and skip because we have visited it.So, we missed
package-cycle-extraneous-2
and it looks like a bug.I replaced depth-first search to breadth-first search. Now it works well.
Types of changes
Checklist: