New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(version): pass --atomic
to git push
#2393
Conversation
It's weird that CI is failed with:
Seems this PR has nothing to do with it. |
Yeah, the Windows tests are flaky due to environmental issues. I kicked it again and it passed. /shrug |
Thanks! |
We need an option to disable this as azure devops git apparently does not support atomic push
|
@amirburbea That's fair. Probably should be resilient to this type of failure and re-attempt without the |
@amirburbea Fixed in v3.20.1 |
Wow! That's fast. Thanks. |
Are you sure that's fixed in v3.20.1? I am seeing that version fail: "error: unknown option `atomic'" |
@evocateur, I am sorry to mention you in a closed issue but today I updated to lerna 3.20.2 and the error below broken my build. I want to give you more context to reconsider the amirburbea's suggestion to add an option to disable the atomic flag.
This error occurred in a Windows 2019 Server using Azure Pipelines. At line 6f0e2bb#diff-4a3a3aa992c599b130c66225bed2e8f4R16 lerna searchs for "atomic" on stderr. This is the expected default behavior of git but it can be changed using the environment variable GIT_REDIRECT_STDERR. This is a valid option for git and it is used to workaround a new behavior of Windows Server 2019 where it handles messages on stderr as errors. More details about this in https://github.com/microsoft/azure-pipelines-image-generation/issues/740 and dahlbyk/posh-git#109. In practice, lerna is not more compatible with Azure Pipelines on Windows Server 2019 and the suggested option can restore this compatibility. For now, I have reverted to an older version of lerna. Thanks for your attention and for this great project. |
@paulocmoreno Ok, I suppose we should check |
@evocateur I created #2467 for your consideration. Thanks for your attention. |
Fix #2392
Description
Pass
--atomic
togit push
. See git's docMotivation and Context
As #2392 said.
How Has This Been Tested?
Tested manually.
Types of changes
Checklist: