Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(link): enable strict type checking for link command #3580

Merged
merged 6 commits into from Mar 20, 2023

Conversation

amorscher
Copy link
Contributor

@amorscher amorscher commented Mar 9, 2023

Removed some ts-ignore comments and any types

Description

Motivation and Context

Make link command lib more typesafe

How Has This Been Tested?

Existing unit and regression test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

 - removed some ts-ignore comments and any types
@amorscher
Copy link
Contributor Author

@JamesHenry @fahslaj I don't know what the cause for the failing task is. Can anyone of you give me a hint?

@JamesHenry
Copy link
Member

Sorry for the delay @amorscher please don't update this to the latest just yet, we want to do it later on our side when we can observe it in real time

@JamesHenry
Copy link
Member

We will be rolling out a fix on Monday to address the issue with the CI runs, so I will take another look at this next week once that fix is available

@amorscher
Copy link
Contributor Author

amorscher commented Mar 18, 2023

OK good. Just out of interest, what is the problem concerning ci runs?

@JamesHenry JamesHenry merged commit 1ade856 into lerna:main Mar 20, 2023
@JamesHenry
Copy link
Member

@amorscher There was a bug with Nx Cloud which we have fixed today. Many thanks again!

Please hold fire on add, bootstrap and link commands now, they are being refactored

@amorscher
Copy link
Contributor Author

@JamesHenry Ok great!

So I am currently working on the version command which is quite a big one...

Shall I create an Issue to track current work regarding type checking support?

@amorscher amorscher deleted the ts-fixes-link-cmd branch March 29, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants