Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try upgrade tar with passing jobs #3996

Closed
wants to merge 1 commit into from

Conversation

mvanzoest
Copy link

tar bump and apparently all Main Job jobs have been failing since April 5. Only change was to the pnpm readme, this PR is testing reverting that change to see it is linked to the issue.

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@@ -5,7 +5,7 @@ Lerna can be used in a [`pnpm` workspace](https://pnpm.io/workspaces) to get the
When used in a `pnpm` workspace, Lerna will:

- resolve package locations with `pnpm-workspace.yaml` (https://pnpm.io/workspaces)
- ignore `"workspaces"` in `package.json`
- enforce `useWorkspaces: true` in `lerna.json` (and ignore `packages:` in `package.json`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't make sense, please revert. There is no packages property in package.json, there is a workspaces property as was stated before

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Main Job has been failing since April 5. This PR was a test to rule out the possibility, however small, that this change made on April 4 contributed to it. As expected, it did not, so will close; the actual PR to upgrade tar is #3990

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the issue seems to be pnpm v9

@mvanzoest mvanzoest closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants