Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fix when script run with TamperMonkey or GreaseMonkey #3655

Closed
langren1353 opened this issue Oct 10, 2021 · 2 comments
Closed

Try fix when script run with TamperMonkey or GreaseMonkey #3655

langren1353 opened this issue Oct 10, 2021 · 2 comments

Comments

@langren1353
Copy link
Contributor

When useing TamperMonkey or GreaseMonkey with less.js as a @require resource, sometimes there will be an error.
I trace the code found a small problem.
At https://github.com/less/less.js/blob/master/packages/less/src/less-browser/utils.js
function addDataAttrs param tag may be null, then the script will exec failed.
A short if may fix this, will you please add the code to check if tag is null

@iChenLei
Copy link
Member

Hi, @langren1353 PR welcome !

@langren1353
Copy link
Contributor Author

Well, I submit one RP, hope that would work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants