Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3655 for param tag is null #3656

Merged
merged 1 commit into from Nov 11, 2021
Merged

fix #3655 for param tag is null #3656

merged 1 commit into from Nov 11, 2021

Conversation

langren1353
Copy link
Contributor

fix when script run with TamperMonkey or GreaseMonkey tag is null
#3655 fix this

@langren1353
Update utils.js
022874a 
fix when script run with TamperMonkey or GreaseMonkey tag is null
@iChenLei
Copy link
Member

Can you add a minimal test case for this PR ? Thanks

@langren1353
Copy link
Contributor Author

For this problem, I don't know to write a test case.
I reviewed the test case for less(css) code, I know how, but for this, I don't know how to write that

iChenLei
iChenLei approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@iChenLei iChenLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iChenLei iChenLei merged commit f613188 into less:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iChenLei iChenLei iChenLei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@langren1353 @iChenLei