Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2991 #3649

Merged
merged 3 commits into from
Aug 20, 2022
Merged

Fix #2991 #3649

merged 3 commits into from
Aug 20, 2022

Conversation

MoonCoral
Copy link
Contributor

Closes #2991

Only comments have isSilent as far as I could see. No comment should cause a parent to be printed in the 'referenced' case.
Thus I'm not even sure what the condition I deleted aimed to achieve.

Test is based on the snipped posted in #2991. css-3.css contained an empty @ rule, I assume to bypass the issue raised in #2991.

@MoonCoral
Copy link
Contributor Author

Test failure seems to be a change of formatting of an error message in node 16. I don't see any relation to my changes.

 - /home/runner/work/less.js/less.js/packages/test-data/errors/eval/javascript-error: FAIL
SyntaxError: JavaScript evaluation error: 'TypeError: Cannot read property 'toJS' of undefined' in /home/runner/work/less.js/less.js/packages/test-data/errors/eval/javascript-error.less on line 2, column 10:¶
SyntaxError: JavaScript evaluation error: 'TypeError: Cannot read properties of undefined (reading 'toJS')' in /home/runner/work/less.js/less.js/packages/test-data/errors/eval/javascript-error.less on line 2, column 10:¶
1 .scope {
2     var: `this.foo.toJS`;
3 }

@iChenLei
Copy link
Member

@MoonCoral Yes, it's not your issue.
@matthew-dean Hi, Matthew. What't your opinion about this CI failure case ?

@iChenLei iChenLei mentioned this pull request Oct 4, 2021
@iChenLei
Copy link
Member

iChenLei commented Oct 7, 2021

@MoonCoral Please update your branch, upstream master branch solved the CI problem.

@MoonCoral
Copy link
Contributor Author

Rebased on master

@iChenLei
Copy link
Member

@MoonCoral CI has been fixed, please update your work, thanks !

@matthew-dean
Copy link
Member

If all other tests pass, this seems good.

@matthew-dean matthew-dean merged commit eefe33a into less:master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty @media queries generated when compiling less file with (reference) to bootstrap
3 participants