fix: Fix https failures on macOS #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was traced upstream to needle, and resolved in: - tomas/needle#392 - tomas/needle#394 - tomas/needle#396 - tomas/needle#398 Closes less#3693
|
Thank you. @matthew-dean Hi, sir. Please review this pr. |
|
lgtm |
matthew-dean
approved these changes
Apr 21, 2022
|
@iChenLei, @matthew-dean, when could we expect to see this in an official release so that we can stop using a fork? |
lumburr
pushed a commit
to lumburr/less.js
that referenced
this pull request
Apr 28, 2022
The issue was traced upstream to needle, and resolved in: - tomas/needle#392 - tomas/needle#394 - tomas/needle#396 - tomas/needle#398 Closes less#3693
|
@matthew-dean Can we release a new version for this bugfix ? |
|
Any chance we could get an updated release for less.js so we can stop using a fork? |
|
Less v4.2.0 seems to include the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was traced upstream to needle, and resolved in:
Closes #3693
What: Fix macOS ECONNRESET w/ node v14+
Why: Without the upgrade to needle, some more complex less files with https inline imports can fail with ECONNRESET, specifically on macOS w/ node v14+
How: The root cause was traced to the dependency
needle, and fixed there over several PRs addressing various combinations of OS and node versionChecklist: