Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Modify this pointer so that it is not empty. #3719

Merged
merged 2 commits into from
Aug 20, 2022
Merged

refactor: Modify this pointer so that it is not empty. #3719

merged 2 commits into from
Aug 20, 2022

Conversation

lumburr
Copy link
Contributor

@lumburr lumburr commented Apr 25, 2022

What: get correct this

Why:
this === undefined

less.js/packages/less/src/less/functions/number.js

Line 54 in 1eafc06

args = order.map(function (a) { return a.toCSS(this.context); }).join(this.context.compress ? ',' : ', ');

image

How:

Checklist:

  • Documentation N/A
  • Added/updated unit tests N/A
  • Code complete

@iChenLei
Copy link
Member

Can you add special unit tests for this PR ? Thanks

@lumburr
Copy link
Contributor Author

lumburr commented Apr 26, 2022

@iChenLei I've added some special test cases.:sweat_smile:

@matthew-dean matthew-dean merged commit 94b2cb4 into less:master Aug 20, 2022
@MagpieRook MagpieRook mentioned this pull request Jan 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-dean matthew-dean matthew-dean approved these changes

@iChenLei iChenLei iChenLei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lumburr @iChenLei @matthew-dean