ci: update the ci config #3789
Merged
ci: update the ci config #3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the Node.js version in the matrix tests from v16 to the latest LTS version, v18, and add tests for Node.js v19.
iChenLei
commented
Apr 2, 2023
| @@ -21,18 +21,6 @@ jobs: | |||
| with: | |||
| # The Node.js version to configure | |||
| node-version: ${{ matrix.node }} | |||
| # Caching dependencies to speed up workflows | |||
There was a problem hiding this comment.
remove the npm cache logic ( it's not very useful
iChenLei
commented
Apr 4, 2023
| @@ -18,10 +18,6 @@ merge of your pull request! | |||
|
|
|||
| **Why**: | |||
|
|
|||
| <!-- How were these changes implemented? --> | |||
iChenLei
commented
Apr 4, 2023
| @@ -2,7 +2,11 @@ | |||
| name: Nodejs Test | |||
|
|
|||
| # Triggers the workflow on push or pull request events | |||
| on: [push, pull_request] | |||
| on: | |||
| push: | |||
There was a problem hiding this comment.
reduce redundant ci trigger
matthew-dean
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Change the github actions ci config
Why:
Current Node.js LTS version is v18, and v19 has been released.
How:
Change the Node.js version in the matrix tests from v16 to the latest LTS version, v18, and add tests for Node.js v19.
Checklist: