Master container style fix for 4235 #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse the correct entities for a comma separated list so that all URLs are rewritten correctly.
matthew-dean
approved these changes
Nov 13, 2023
iChenLei
approved these changes
Nov 14, 2023
matthew-dean
requested changes
Nov 21, 2023
There was a problem hiding this comment.
style is much too specific. More function-like constructs are being added and more may follow. Please make parsing more generic and look at function parsing to correctly capture parsing here.
fixes issue less#4235 where container query style would have invalid space after keyword
puckowski
force-pushed
the
master_container_style
branch
from
90379d6
to
aa60398
Compare
|
Rewrote solution to use function parsing to be more flexible for future functions in declarations of at-rules. Updated container at-rule tests. Tests pass locally. @matthew-dean |
matthew-dean
approved these changes
Dec 18, 2023
|
@puckowski Thanks! |
|
@iChenLei Do you believe we can merge this pull request? |
|
@matthew-dean Do you believe we can merge this pull request? I'd like to update some dependent projects to add support for |
|
@puckowski Oh yup, let's do it. Holidays + covid made me miss this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes issue #4235
stylekeyword would have invalid space after keyword in container queries.Why:
With the invalid space, the CSS is not parsed correctly by browsers.
Checklist:
Tests passing locally. Updated one test case for container queries.